fix(resolve): handle exports field w/ mapped directory

vitejs · Jan 5, 2021 · 724aa8a · 724aa8a
1 parent bcdade3
commit 724aa8a
Show file tree

Hide file tree

Showing 5 changed files with 51 additions and 8 deletions.
diff --git a/packages/playground/resolve/__tests__/resolve.spec.ts b/packages/playground/resolve/__tests__/resolve.spec.ts
@@ -10,6 +10,18 @@ test('deep import with exports field', async () => {
   expect(await page.textContent('.exports-deep')).toMatch('[success]')
 })
 
+test('deep import with exports field + exposed dir', async () => {
+  expect(await page.textContent('.exports-deep-exposed-dir')).toMatch(
+    '[success]'
+  )
+})
+
+test('deep import with exports field + mapped dir', async () => {
+  expect(await page.textContent('.exports-deep-mapped-dir')).toMatch(
+    '[success]'
+  )
+})
+
 test('omitted index/*', async () => {
   expect(await page.textContent('.index')).toMatch('[success]')
 })

diff --git a/packages/playground/resolve/conditional-exports/dir/dir.js b/packages/playground/resolve/conditional-exports/dir/dir.js
@@ -0,0 +1 @@
+export const msg = '[success] mapped directory from exports'
diff --git a/packages/playground/resolve/conditional-exports/package.json b/packages/playground/resolve/conditional-exports/package.json
@@ -6,6 +6,11 @@
       "import": "./main.js",
       "require": "./cjs.js"
     },
-    "./deep.js": "./deep.js"
+    "./deep.js": "./deep.js",
+    "./dir/": "./dir/",
+    "./dir-mapped/": {
+      "import": "./dir/",
+      "require": "./dir-cjs/"
+    }
   }
 }
diff --git a/packages/playground/resolve/index.html b/packages/playground/resolve/index.html
@@ -9,6 +9,12 @@ <h2>Entry resolving with exports field</h2>
 <h2>Deep import with exports field</h2>
 <p class="exports-deep">fail</p>
 
+<h2>Deep import with exports field + exposed directory</h2>
+<p class="exports-deep-exposed-dir">fail</p>
+
+<h2>Deep import with exports field + mapped directory</h2>
+<p class="exports-deep-mapped-dir">fail</p>
+
 <h2>Resolve /index.*</h2>
 <p class="index">fail</p>
 
@@ -57,6 +63,14 @@ <h2>Inline package</h2>
   import { msg as deepMsg } from 'resolve-conditional-exports/deep.js'
   text('.exports-deep', deepMsg)
 
+  // deep import w/ exposed dir
+  import { msg as exposedDirMsg } from 'resolve-conditional-exports/dir/dir'
+  text('.exports-deep-exposed-dir', exposedDirMsg)
+
+  // deep import w/ mapped dir
+  import { msg as mappedDirMsg } from 'resolve-conditional-exports/dir-mapped/dir'
+  text('.exports-deep-mapped-dir', mappedDirMsg)
+
   // implicit index resolving
   import { foo } from './util'
   text('.index', foo())

diff --git a/packages/vite/src/node/plugins/resolve.ts b/packages/vite/src/node/plugins/resolve.ts
@@ -417,13 +417,24 @@ function resolveDeepImport(
 
   // map relative based on exports data
   if (exportsField) {
-    if (
-      isObject(exportsField) &&
-      !Array.isArray(exportsField) &&
-      relativeId in exportsField
-    ) {
-      relativeId = resolveConditionalExports(exportsField[relativeId])
-    } else {
+    let isExported = false
+    if (isObject(exportsField) && !Array.isArray(exportsField)) {
+      if (relativeId in exportsField) {
+        relativeId = resolveConditionalExports(exportsField[relativeId])
+        isExported = true
+      } else {
+        for (const key in exportsField) {
+          if (key.endsWith('/') && relativeId.startsWith(key)) {
+            // directory mapping
+            const replacement = resolveConditionalExports(exportsField[key])
+            relativeId = replacement && relativeId.replace(key, replacement)
+            isExported = true
+            break
+          }
+        }
+      }
+    }
+    if (!isExported || !relativeId) {
       throw new Error(
         `Package subpath '${relativeId}' is not defined by "exports" in ` +
           `${path.join(dir, 'package.json')}.`