test: add test in ssr-react

vitejs · Nov 25, 2021 · eb5c246 · eb5c246
1 parent 083f9f9
commit eb5c246
Show file tree

Hide file tree

Showing 3 changed files with 31 additions and 5 deletions.
diff --git a/packages/playground/ssr-react/__tests__/ssr-react.spec.ts b/packages/playground/ssr-react/__tests__/ssr-react.spec.ts
@@ -1,6 +1,8 @@
 import { editFile, untilUpdated } from '../../testUtils'
 import { port } from './serve'
 import fetch from 'node-fetch'
+import { resolve } from 'path'
+import promises from 'fs/promises'
 
 const url = `http://localhost:${port}`
 
@@ -62,3 +64,12 @@ test(`circular dependecies modules doesn't throw`, async () => {
     'circ-dep-init-a circ-dep-init-b'
   )
 })
+
+test('Home chunk file should be split succeed', async () => {
+  const assetsArr = await promises.readdir(
+    resolve(process.cwd(), './packages/temp/ssr-react/dist/client/assets')
+  )
+  const re = /Home\.chunk/
+  const res = assetsArr.some((asset) => re.test(asset))
+  expect(res).toBe(true)
+})
diff --git a/packages/playground/ssr-react/vite.config.js b/packages/playground/ssr-react/vite.config.js
@@ -6,6 +6,13 @@ const react = require('@vitejs/plugin-react')
 module.exports = {
   plugins: [react()],
   build: {
-    minify: false
+    minify: false,
+    manualChunks: (config) => {
+      return (id) => {
+        if (id.includes('Home.jsx')) {
+          return 'Home.chunk'
+        }
+      }
+    }
   }
 }
diff --git a/packages/vite/src/node/build.ts b/packages/vite/src/node/build.ts
@@ -235,7 +235,11 @@ export type ResolvedBuildOptions = Required<
   Omit<
     BuildOptions,
     // make deprecated options optional
-    'base' | 'cleanCssOptions' | 'polyfillDynamicImport' | 'brotliSize' | 'manualChunks'
+    | 'base'
+    | 'cleanCssOptions'
+    | 'polyfillDynamicImport'
+    | 'brotliSize'
+    | 'manualChunks'
   >
 >
 
@@ -509,7 +513,7 @@ async function doBuild(
           !libOptions &&
           output?.format !== 'umd' &&
           output?.format !== 'iife'
-            ? (createMoveToVendorChunkFn(config) && config.build.manualChunks?.(config))
+            ? createManualChunksFn(config)
             : undefined,
         ...output
       }
@@ -637,16 +641,20 @@ function getPkgName(root: string) {
   return name?.startsWith('@') ? name.split('/')[1] : name
 }
 
-function createMoveToVendorChunkFn(config: ResolvedConfig): GetManualChunk {
+function createManualChunksFn(config: ResolvedConfig): GetManualChunk {
   const cache = new Map<string, boolean>()
-  return (id, { getModuleInfo }) => {
+  return (id, { getModuleInfo, getModuleIds }) => {
     if (
       id.includes('node_modules') &&
       !isCSSRequest(id) &&
       staticImportedByEntry(id, getModuleInfo, cache)
     ) {
       return 'vendor'
     }
+    return config.build.manualChunks?.(config)(id, {
+      getModuleInfo,
+      getModuleIds
+    })
   }
 }