fix(scan): skip non-absolute resolved paths during scan

vitejs · Jan 31, 2021 · f635971 · f635971
1 parent febff7b
commit f635971
Showing 1 changed file with 5 additions and 12 deletions.
diff --git a/packages/vite/src/node/optimizer/scan.ts b/packages/vite/src/node/optimizer/scan.ts
@@ -11,11 +11,8 @@ import {
   isObject,
   cleanUrl,
   externalRE,
-  dataUrlRE,
-  isExternalUrl,
-  isDataUrl
+  dataUrlRE
 } from '../utils'
-import { browserExternalId } from '../plugins/resolve'
 import {
   createPluginContainer,
   PluginContainer
@@ -345,20 +342,16 @@ async function transformGlob(source: string, importer: string) {
 }
 
 export function shouldExternalizeDep(resolvedId: string, rawId?: string) {
-  // virtual id
-  if (resolvedId === rawId || resolvedId.includes('\0')) {
+  // not a valid file path
+  if (!path.isAbsolute(resolvedId)) {
     return true
   }
-  // browser external
-  if (resolvedId.startsWith(browserExternalId)) {
+  // virtual id
+  if (resolvedId === rawId || resolvedId.includes('\0')) {
     return true
   }
   // resovled is not a js type
   if (!jsTypesRE.test(resolvedId)) {
     return true
   }
-  // external or data url
-  if (isExternalUrl(resolvedId) || isDataUrl(resolvedId)) {
-    return true
-  }
 }