fix(client): serve client sources next to deployed scripts #11865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As detailed in https://crbug.com/1411596, Vite currently serves its own client sources under `<origin>/src/client/*.ts`, which is confusing for developers that expect to find only their own code within `/src/`. Ideally the `client.ts`, `overlay.ts`, and `env.ts` would just appear next to their deployed counterparts, which can be accomplished by making sure that the sourcemaps generated by rollup contain only the file name without any additional relative path (which the DevTools will not be able to resolve meaningfully for at least `/@vite/client`). Ref: https://crbug.com/1411596 Demo: https://github.com/jecfish/coffee-cart
patak-dev
approved these changes
Jan 31, 2023
|
/ecosystem-ci run |
|
📝 Ran ecosystem CI: Open
|
sapphi-red
approved these changes
Feb 1, 2023
futurGH
pushed a commit
to futurGH/vite
that referenced
this pull request
Feb 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As detailed in https://crbug.com/1411596, Vite currently serves its own client sources under
<origin>/src/client/*.ts, which is confusing for developers that expect to find only their own code within/src/.Ideally the
client.ts,overlay.ts, andenv.tswould just appear next to their deployed counterparts, which can be accomplished by making sure that the sourcemaps generated by rollup contain only the file name without any additional relative path (which the DevTools will not be able to resolve meaningfully for at least/@vite/client).Additional context
Ref: https://crbug.com/1411596
Demo: https://github.com/jecfish/coffee-cart (@jecfish)
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).