Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font tilt style invalidated #12545

Closed
7 tasks done
ProudMuBai opened this issue Mar 23, 2023 · 5 comments
Closed
7 tasks done

Font tilt style invalidated #12545

ProudMuBai opened this issue Mar 23, 2023 · 5 comments

Comments

@ProudMuBai
Copy link

Describe the bug

Using the font tilt style in the vite project does not seem to work, The same is true with the online program available on the vite website.

Reproduction

https://stackblitz.com/edit/vitejs-vite-9mzajn?file=index.html&terminal=dev

Steps to reproduce

image

System Info

No error message was generated

Used Package Manager

npm

Logs

No response

Validations

@stackblitz
Copy link

stackblitz bot commented Mar 23, 2023

Fix this issue in StackBlitz Codeflow Start a new pull request in StackBlitz Codeflow.

@fi3ework
Copy link
Member

Could not reproduce in stackblitz, it is probably not related to Vite but something with your browser's global style (maybe third-party extensions, could use incognito mode to eliminate the interference of extensions).
image

@fi3ework fi3ework added cannot reproduce The bug cannot be reproduced and removed pending triage labels Mar 23, 2023
@ProudMuBai
Copy link
Author

Thank you for your answer, this is not the problem of vite itself, I have found the reason, is the effect of (font-family: system-ui) in the style.css file generated by the project template created by vite; You need to lower the matching priority of 'system-ui' or use the appropriate system font to display properly
image

@fi3ework
Copy link
Member

The reason is Microsoft Yahei UI performs badly in Windows. A long discussion here iFixit/core-primitives#36. I'm not sure if should we place Segoe UI before system-ui as many of the big platforms (such as GitHub) also put system-ui in the front.

@fi3ework fi3ework added enhancement: pending triage and removed cannot reproduce The bug cannot be reproduced labels Mar 23, 2023
@bluwy
Copy link
Member

bluwy commented Mar 29, 2023

Since this is a machine-specific font rendering issue, I don't think we should change our defaults to cater for it. We put Inter first as that matches the "Vite theme" (the docs uses it too), but if not we fallback to system-ui. Closing for now.

@bluwy bluwy closed this as not planned Won't fix, can't repro, duplicate, stale Mar 29, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Apr 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants