Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle try-catch for fs promise when resolve https config #12808

Merged
merged 2 commits into from
Apr 10, 2023
Merged

fix: handle try-catch for fs promise when resolve https config #12808

merged 2 commits into from
Apr 10, 2023

Conversation

windsonR
Copy link
Contributor

Description

Since PR: #12553, it use fsp to replace fs.

And, in http.ts, the try-catch can't catch promise's error.

This makes that when these config maybe not a actual path (such as @vitejs/plugin-basic-ssl), it will throw an error and try-catch can NOT catch this error then http server start fail.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@stackblitz
Copy link

stackblitz bot commented Apr 10, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@bluwy bluwy changed the title fix: try-catch can't cover promise's error when resolve https config fix: handle try-catch for fs promise when resolve https config Apr 10, 2023
@bluwy bluwy added the p4-important Violate documented behavior or significantly improves performance (priority) label Apr 10, 2023
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this!

@bluwy bluwy enabled auto-merge (squash) April 10, 2023 17:06
@bluwy bluwy merged commit 0bba402 into vitejs:main Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p4-important Violate documented behavior or significantly improves performance (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants