Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(eslint): migrate to eslint-plugin-n #12895

Merged
merged 2 commits into from Apr 18, 2023
Merged

Conversation

antfu
Copy link
Member

@antfu antfu commented Apr 18, 2023

Description

eslint-plugin-node is no longer maintained, migrate to
https://github.com/eslint-community/eslint-plugin-n

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@stackblitz
Copy link

stackblitz bot commented Apr 18, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

],
'node/no-missing-require': [
'n/no-process-exit': 'off',
'n/no-missing-import': 'off',
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I disabled this because I consider TypeScript already covers it.

.eslintrc.cjs Outdated Show resolved Hide resolved
Co-authored-by: Bjorn Lu <bjornlu.dev@gmail.com>
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great locally for me

@patak-dev patak-dev enabled auto-merge (squash) April 18, 2023 11:41
@patak-dev patak-dev merged commit 62ebe28 into main Apr 18, 2023
12 checks passed
@patak-dev patak-dev deleted the chore/use-eslint-plugin-n branch April 18, 2023 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants