Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: lightningCSS should load external URL in CSS file #13692

Merged
merged 2 commits into from Jul 3, 2023
Merged

fix: lightningCSS should load external URL in CSS file #13692

merged 2 commits into from Jul 3, 2023

Conversation

Marabyte
Copy link
Contributor

Description

Fixes a bug when using LightningCSS as CSS processor and the CSS file includes an url() pointing to an external asset.

Additional context

Fixes #13650

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@Marabyte Marabyte changed the title reproduce error Build fails in v4.4-beta with LightningCSS and external URL in CSS file Jun 30, 2023
@Marabyte Marabyte changed the title Build fails in v4.4-beta with LightningCSS and external URL in CSS file fix: LightningCSS should load external URL in CSS file Jun 30, 2023
@Marabyte Marabyte changed the title fix: LightningCSS should load external URL in CSS file fix: lightningCSS should load external URL in CSS file Jun 30, 2023
@ArnaudBarre ArnaudBarre marked this pull request as ready for review July 3, 2023 00:25
@ArnaudBarre ArnaudBarre added this to the 4.4 milestone Jul 3, 2023
@patak-dev patak-dev merged commit 8517645 into vitejs:main Jul 3, 2023
13 checks passed
@ArnaudBarre
Copy link
Member

Thanks a lot for testing the beta version and the test case @Marabyte 🙏

@Marabyte Marabyte deleted the bug/lightning-external-url branch July 3, 2023 16:19
xinxinhe1810 pushed a commit to xinxinhe1810/vite that referenced this pull request Jul 4, 2023
@Marabyte @ArnaudBarre @xinxinhe1810
fix: lightningCSS should load external URL in CSS file (vitejs#13692)
c4b6a63 
Co-authored-by: Arnaud Barré <arnaud.barre@carbometrix.com>
@juliendargelos juliendargelos mentioned this pull request Sep 30, 2023
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patak-dev patak-dev patak-dev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.

Build fails in v4.4-beta with LightningCSS and external URL in CSS file
3 participants
@Marabyte @ArnaudBarre @patak-dev