fix: excessive quoting in rewritten css urls #1399
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like windows tests are failing due to this change. |
|
closing in favor of #1412 |
|
#1412 is concerned with data URLs, this PR is not. |
Using JSON.stringify is unnecessary, since `rewriteCssUrls` wraps the url with quotes already. Checking for external urls and data urls is also unnecessary, since `rewriteCssUrls` does that too.
|
There are failing test cases - make sure to add tests for intended fix and have all tests pass locally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
JSON.stringifyis unnecessary, sincerewriteCssUrlswraps the url with quotes already. Checking for external urls and data urls is also unnecessary, sincerewriteCssUrlsdoes that too.