Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(css): initialize lightningCSS targets when not using options #14872

Merged
merged 2 commits into from Nov 5, 2023

Conversation

ArnaudBarre
Copy link
Member

This was a weird behaviour where:

css: {
  transformer: "lightningcss",
},

was not the same as

css: {
   transformer: "lightningcss",
   lightningcss: {},
},

Because without any targets LightningCSS will default to latest specs and do a lot of syntax shortening and vendor-prefixing cleanup, this should always be set to avoid sending non supported CSS to the browser.

@ArnaudBarre ArnaudBarre self-assigned this Nov 3, 2023
Copy link

stackblitz bot commented Nov 3, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@ArnaudBarre ArnaudBarre added the p2-edge-case Bug, but has workaround or limited in scope (priority) label Nov 3, 2023
@bluwy bluwy merged commit 12f9230 into main Nov 5, 2023
10 checks passed
@bluwy bluwy deleted the arnaud/fix-lightningcss-options branch November 5, 2023 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat: css p2-edge-case Bug, but has workaround or limited in scope (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants