New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(plugin-dynamic-import): add assetDir in module path #1610

Merged

yyx990803 merged 2 commits into vitejs:main from AlexandreBonaventure:dynamic-import-patch

Jan 20, 2021

Contributor

AlexandreBonaventure commented Jan 20, 2021

This is fixing dynamic import polyfill by adding the assets dir in the basePath

Screenshot above highlights the issue (run the app in edge 18)

repro: https://github.com/AlexandreBonaventure/vite-dynamic-import-bug

AlexandreBonaventure and others added 2 commits

January 20, 2021 11:03


          fix(plugin-dynamic-import): add assetDir in module path

df7f85a


          Update dynamicImportPolyfill.ts

e2c70c1

yyx990803 merged commit 47ff0f4 into vitejs:main

Member

yyx990803 commented Jan 20, 2021 •

edited

Loading

oops, accidentally removed the path import. will fix in another commit. 1c62706

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet