changelog links are broken

[fz6m]

Documentation is

• Missing
• Outdated
• Confusing
• Not sure?

Explain in Detail

I often check the changelog, but this time many links were broken 🥲

See

• https://github.com/vitejs/vite/blob/v6.0.0-alpha.13/packages/vite/CHANGELOG.md

Your Suggestion for Changes

Add PR link

Reproduction

No response

Steps to reproduce

No response

[bluwy]

We probably need to use the full commit hash in the linked url - conventional-changelog/conventional-changelog#476

However the linked issue doesn't seem to have a direct solution, and I haven't investigated if we can tweak this directly. Strangely though, the short commit hash shouldn't be colliding since it's displaying fine for me locally:

> git rev-parse 82111bf  
82111bfb4134646f5ea03a6bead16ebdf67bbe15

A shorter hash would look like:

> git rev-parse 8211     
error: short object ID 8211 is ambiguous
hint: The candidates are:
hint:   82111bfb4 commit 2024-05-20 - fix: types
hint:   82116a58c tree
hint:   8211f8632 blob
8211
fatal: ambiguous argument '8211': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'

Maybe GitHub collects more hashes not cloned locally.

[btea]

@bluwy It seems that the upstream has not planned to solve this problem for a long time. Perhaps we can add a script to replace the short hash with the full hash value.

[bluwy]

Fine by me 👍 Maybe we can also use pnpm to patch it.

[btea]

conventional-changelog is called directly with npx, and I don't know how to patch it. Currently, I can only write a script to update the hash value.

[bluwy]

If you want to patch, you can use https://pnpm.io/cli/patch, e.g. pnpm patch conventional-changelog-cli. Though I'm not sure if that's the code we want to edit, you could also pass a nested package name to edit.

[bluwy]

I think we can close this with #17709 merged