Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(create-app): update prompt message based on user input #2103

Merged
merged 2 commits into from
Feb 19, 2021
Merged

fix(create-app): update prompt message based on user input #2103

merged 2 commits into from
Feb 19, 2021

Conversation

jamesgeorge007
Copy link
Contributor

Follow up of #2072

vite/packages/create-app/index.js

Line 84 in c391ea3

: `${template} isn't a valid template. Please choose from below: `

  • Boolean value for --template.
create-app app -t

boolean-template

  • Not supplying a template.
create-app app

no-template

Patch

Screenshot 2021-02-19 at 9 25 08 PM

CHOYSEN
CHOYSEN suggested changes Feb 19, 2021
View reviewed changes
packages/create-app/index.js Outdated Show resolved Hide resolved
CHOYSEN
CHOYSEN suggested changes Feb 19, 2021
View reviewed changes
packages/create-app/index.js Outdated Show resolved Hide resolved
@jamesgeorge007 @yyx990803 @CHOYSEN
Apply suggestions from code review
076901c 
Co-authored-by: Evan You <yyx990803@gmail.com>
Co-authored-by: CHOYSEN <choysen@qq.com>
@yyx990803 yyx990803 merged commit 038f786 into vitejs:main Feb 19, 2021
@jamesgeorge007 jamesgeorge007 deleted the hotfix/create-app branch February 20, 2021 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CHOYSEN CHOYSEN CHOYSEN requested changes

@yyx990803 yyx990803 Awaiting requested review from yyx990803

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jamesgeorge007 @yyx990803 @CHOYSEN