Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(create-app): update prompt message based on user input #2103

Merged
merged 2 commits into from
Feb 19, 2021
Merged

fix(create-app): update prompt message based on user input #2103

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9038bf4
fix: update prompt message based on user input
jamesgeorge007 Feb 19, 2021
076901c
Apply suggestions from code review
jamesgeorge007 Feb 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions packages/create-app/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,12 +76,17 @@ async function init() {

// determine template
let template = argv.t || argv.template

const availableTemplates = TEMPLATES.map((template) => stripColors(template))
const isValidTemplate = availableTemplates.includes(template)
const message = isValidTemplate
? `Select a template:`
: `${template} isn't a valid template. Please choose from below: `
let message = 'Select a template:'
let isValidTemplate
jamesgeorge007 marked this conversation as resolved.
Show resolved Hide resolved

// --template expects a value
if (template && typeof template === 'string') {
jamesgeorge007 marked this conversation as resolved.
Show resolved Hide resolved
const availableTemplates = TEMPLATES.map((template) =>
stripColors(template)
)
jamesgeorge007 marked this conversation as resolved.
Show resolved Hide resolved
isValidTemplate = availableTemplates.includes(template)
message = `${template} isn't a valid template. Please choose from below:`
}

if (!template || !isValidTemplate) {
/**
Expand Down