fix(css): using background url which match alias in sass/less, there will be link error (fix #2316) #2323
Conversation
|
The error prompt is shown in the figure below.
After I run Maybe my fix way is not very elegant, I hope someone can guide me. Thanks. |
crcong
changed the title
| @@ -848,6 +851,7 @@ type StylePreprocessor = ( | |||
| [key: string]: any | |||
| additionalData?: PreprocessorAdditionalData | |||
| filename: string | |||
| alias: Alias[] | |||
There was a problem hiding this comment.
nitpick (non-blocking): Plural of alias is aliases (applies also to other lines)
There was a problem hiding this comment.
Thank you for your advice. I've changed the name of alias to aliases.
There was a problem hiding this comment.
Sorry for going against this change, but we are using alias in other config options, and it is a string of aliases https://vitejs.dev/config/#resolve-alias. It is strange in the code to see aliases = config.resolve.alias. I think the singular form was ok here. @Shinigami92 @crcong what do you think?
There was a problem hiding this comment.
Mh I complained about it, because it was passed and always used as an array (in this PR)
In convention perspective this would mean that it should be named in plural form
Keep in mind that it is only a code change right now and not a breaking change, so config.resolve.alias is still config.resolve.alias in the public exposed API
There was a problem hiding this comment.
I found that the configuration config.resolve.alias has been processed into an array inside vite, so I also think it is ok to use the singular here. I will change it back. @Shinigami92 @matias-capeletto Thank you for your suggestions.
There was a problem hiding this comment.
Okay, sorry for the inconvenience 😅
patak-dev
added
the
p3-minor-bug
vitejs#2316) (vitejs#2323)" This reverts commit 9499d26.
After testing in playground, I found that when using background url which contains alias in sass/less, there will be link error scenarios.(fix #2316)