fix: reload only once on socket reconnect #2340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjk
commented
Mar 2, 2021
packages/vite/src/client/client.ts
Outdated
| @@ -172,9 +172,10 @@ async function queueUpdate(p: Promise<(() => void) | undefined>) { | |||
| socket.addEventListener('close', ({ wasClean }) => { | |||
| if (wasClean) return | |||
| console.log(`[vite] server connection lost. polling for restart...`) | |||
| setInterval(() => { | |||
| const interval = setInterval(() => { | |||
| fetch(`${base}__vite_ping`) | |||
There was a problem hiding this comment.
I suppose this solution is not perfect if the fetch takes longer than the interval... but we can maybe ignore that very unlikely possibility (chain setTimeout would be safer)
There was a problem hiding this comment.
Yeah I think it's better to refactor it to use chained setTimeout instead.
Shinigami92
approved these changes
Mar 23, 2021
Shinigami92
added
p2-nice-to-have
patak-dev
approved these changes
Mar 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Network without the patch:
With the patch: