Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ssr): handle empty sourcemaps (fix #2391) #2441

Merged
merged 2 commits into from
Mar 15, 2021
Merged

fix(ssr): handle empty sourcemaps (fix #2391) #2441

merged 2 commits into from
Mar 15, 2021

Conversation

GrygrFlzr
Copy link
Member

Closes #2391

  • Swaps out the unmaintained merge-source-maps dependency with @ampproject/remapping for better future-proofing.
  • In the case of empty sourcemaps, skip the merging process.

benmccann
benmccann previously approved these changes Mar 9, 2021
View reviewed changes
Copy link
Collaborator

@benmccann benmccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is great! thank you so much!

packages/vite/src/node/utils.ts Outdated Show resolved Hide resolved
@benmccann benmccann mentioned this pull request Mar 9, 2021
Closed
@7antra
Copy link

7antra commented Mar 10, 2021

Many thanks !!!!

@fernandolguevara
Copy link

thanks!!!

@Malwurf
Copy link

Malwurf commented Mar 10, 2021

great!

antony
antony previously approved these changes Mar 12, 2021
View reviewed changes
@benmccann benmccann mentioned this pull request Mar 12, 2021
Closed
Malwurf
Malwurf previously approved these changes Mar 12, 2021
View reviewed changes
@rmunn rmunn mentioned this pull request Mar 12, 2021
Closed
@antfu antfu dismissed stale reviews from Malwurf and antony via 69d937d March 13, 2021 10:11
@antfu antfu added the p4-important Violate documented behavior or significantly improves performance (priority) label Mar 13, 2021
@yyx990803 yyx990803 merged commit 103dec9 into vitejs:main Mar 15, 2021
@benmccann benmccann mentioned this pull request Mar 17, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antfu antfu antfu approved these changes

@antony antony antony left review comments

@benmccann benmccann benmccann left review comments

@Malwurf Malwurf Malwurf left review comments

Assignees
No one assigned
Labels
p4-important Violate documented behavior or significantly improves performance (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SSR source map merging fails on empty file segments (Error: No element indexed by 0)
8 participants
@GrygrFlzr @7antra @fernandolguevara @Malwurf @antony @benmccann @antfu @yyx990803