Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(build): support cssCodeSplit for cjs format #2621

Merged
merged 2 commits into from
Apr 4, 2021
Merged

fix(build): support cssCodeSplit for cjs format #2621

merged 2 commits into from
Apr 4, 2021

Conversation

underfin
Copy link
Member

fix #2575

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Description

Additional context

@Shinigami92 Shinigami92 added 🔍 review needed p3-minor-bug An edge case that only affects very specific usage (priority) labels Mar 21, 2021
Shinigami92
Shinigami92 previously approved these changes Mar 21, 2021
View reviewed changes
Copy link
Member

@Shinigami92 Shinigami92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks okay to me, the AppVeyor error seems not related

aminya
aminya previously approved these changes Mar 23, 2021
View reviewed changes
@patak-dev
Copy link
Member

@underfin I think that you could push to force appveyor to re-run.

Thought, Is there an easy way to add a test for this? (Ok to do this in a different PR).

@antfu antfu dismissed stale reviews from aminya and Shinigami92 via ea0fef7 April 4, 2021 11:36
antfu
antfu approved these changes Apr 4, 2021
View reviewed changes
Copy link
Member

@antfu antfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests added

@antfu antfu requested a review from Shinigami92 April 4, 2021 11:39
@patak-dev patak-dev merged commit 2a89c57 into main Apr 4, 2021
ygj6 pushed a commit to ygj6/vite that referenced this pull request Apr 9, 2021
@underfin @antfu @ygj6
fix(build): support cssCodeSplit for cjs format, fix vitejs#2575 (v…
271fc29 
…itejs#2621)

Co-authored-by: Anthony Fu <anthonyfu117@hotmail.com>
@antfu antfu deleted the fix-cjs-css-chunk branch September 17, 2021 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shinigami92 Shinigami92 Shinigami92 approved these changes

@antfu antfu antfu approved these changes

@patak-dev patak-dev patak-dev approved these changes

@aminya aminya aminya left review comments

Assignees
No one assigned
Labels
p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

when outfile format cjs,import the same css file will import a no exists js file
5 participants
@underfin @patak-dev @Shinigami92 @antfu @aminya