Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix types errors #2726

Merged
merged 1 commit into from
Mar 27, 2021
Merged

fix: fix types errors #2726

merged 1 commit into from
Mar 27, 2021

Conversation

g-plane
Copy link
Contributor

@g-plane g-plane commented Mar 27, 2021 •
edited
Loading

Description

Fixed TypeScript compilation errors.

Additional context

Please merge this pull request as soon as possible, because those compilation errors break several commits in CI.

The bad commit is 1c713f0 .

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@patak-dev patak-dev merged commit 9716582 into vitejs:main Mar 27, 2021
@g-plane g-plane deleted the fix-tsc-errors branch March 27, 2021 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patak-dev patak-dev patak-dev approved these changes

@antfu antfu antfu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@g-plane @patak-dev @antfu