fix(build): properly handle alias key in config merge #2847
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
👋 small bug fix - there's some logic in
mergeConfig
to handle merging particular field types:vite/packages/vite/src/node/config.ts
Lines 520 to 539 in fa85749
Note the custom handling of
alias
at the bottom. In some cases this isn't necessary (i.e. ifexisting
andvalue
are both objects / arrays) though it is if the configs use different alias schemas.It looks like
mergeAlias
is never being run sincealias
is (afaik) never a root key. I tweaked the logic to only perform this check when checking a non-root key.I added a failing test for this case as well as an additional test for the
assetsInclude
(already passes on main).What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).