Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint CI does not run correctly if a lint error occurs #2986

Closed
6 tasks done
Shinigami92 opened this issue Apr 14, 2021 · 0 comments · Fixed by #2988
Closed
6 tasks done

Lint CI does not run correctly if a lint error occurs #2986

Shinigami92 opened this issue Apr 14, 2021 · 0 comments · Fixed by #2988
Assignees
Labels
p1-chore Doesn't change code behavior (priority)

Comments

@Shinigami92
Copy link
Member

Describe the bug

When there is a lint error within e.g. the vite package, then the Lint CI job fails while prepare step instead of reporting lint errors in the specific CI step.

Reproduction

Create a PR and forcefully create an error for the lint step

Example: #2860 (comment)


Before submitting the issue, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the docs.
  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
  • Provide a description in this issue that describes the bug.
  • Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to https://github.com/vuejs/vue-next instead.
  • Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
@Shinigami92 Shinigami92 added pending triage p1-chore Doesn't change code behavior (priority) and removed pending triage labels Apr 14, 2021
@Shinigami92 Shinigami92 self-assigned this Apr 14, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jul 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
p1-chore Doesn't change code behavior (priority)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant