fix: do not cache module while the file contains import.meta.glob #3005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
tests are not successful |
|
@Niputi This error does not seem to be caused by my submission |
|
could you try rebasing against main? |
|
@Niputi done |
|
Personally don't think this is the best way to solve the problem. Introduce fs operations and disable the cache could have certain impact to the pref. Better to track the dependencies and invalid the module on deps changes properly instead. |
|
@antfu Thanks for your suggestion. I re-examined the source code and found that this problem was caused by the invalidate method does not consider the ssr module. I revised it again, please take a look. Thank you very much! |
Schniz
approved these changes
May 20, 2021
Shinigami92
added
feat: ssr
p3-minor-bug
Shinigami92
approved these changes
May 20, 2021
nihalgonsalves
approved these changes
May 20, 2021
ygj6
added a commit
to ygj6/vite
that referenced
this pull request
Jun 1, 2021
…tejs#3005) Co-authored-by: ygj6 <ygj@54321>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
in #2734 , while source file(
app.js) useimport.glob.metato scan/src/data/*.json，while we add a json file such asx.json，the module will hit cache in urlToModuleMap because the source file(app.js) did not change.fix #2734
Additional context