Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dev): rewrite importee path at html files at spa fallback #3239

Merged
merged 1 commit into from
May 10, 2021
Merged

fix(dev): rewrite importee path at html files at spa fallback #3239

merged 1 commit into from
May 10, 2021

Conversation

underfin
Copy link
Member

@underfin underfin commented May 2, 2021

fix: #3230

Description

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@Shinigami92 Shinigami92 marked this pull request as draft May 4, 2021 16:37
@underfin underfin changed the title fix(dev): add /@fs/ for assets inside html fix(dev): rewrite importee path at html files at spa fallback May 4, 2021
@underfin underfin marked this pull request as ready for review May 5, 2021 02:52
@Shinigami92 Shinigami92 added the p3-minor-bug An edge case that only affects very specific usage (priority) label May 6, 2021
@antfu antfu merged commit 13d41d8 into main May 10, 2021
@antfu antfu deleted the fix-assets-html branch May 10, 2021 05:13
fi3ework pushed a commit to fi3ework/vite that referenced this pull request May 22, 2021
@underfin @fi3ework
fix(dev): rewrite importee path at html files at spa fallback (vitejs…
4d9bf92 
…#3239)
@Karnak19 Karnak19 mentioned this pull request Jun 10, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antfu antfu antfu left review comments

@patak-dev patak-dev patak-dev approved these changes

@Shinigami92 Shinigami92 Shinigami92 approved these changes

Assignees
No one assigned
Labels
p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Two-level route with react-router-dom : page don't load
4 participants
@underfin @patak-dev @Shinigami92 @antfu