Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use the closest package.json as root when workspace not found fo… #3374

Merged
merged 1 commit into from
May 12, 2021
Merged

fix: use the closest package.json as root when workspace not found fo… #3374

merged 1 commit into from
May 12, 2021

Conversation

antfu
Copy link
Member

@antfu antfu commented May 12, 2021

…r fsServe

Description

#3373 (comment)

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@antfu
Copy link
Member Author

antfu commented May 12, 2021

Can't add test as it will always resolve to vite's workspace root. Or are we ok to rename workspace's package.json temporary in tests?

@Shinigami92 Shinigami92 added the p3-minor-bug An edge case that only affects very specific usage (priority) label May 12, 2021
Shinigami92
Shinigami92 approved these changes May 12, 2021
View reviewed changes
Copy link
Member

@Shinigami92 Shinigami92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would love to have nightly builds for such things 🙂

@antfu antfu merged commit 42b35ac into vitejs:main May 12, 2021
@antfu antfu deleted the fix/search-root branch May 12, 2021 08:14
fi3ework pushed a commit to fi3ework/vite that referenced this pull request May 22, 2021
@antfu @fi3ework
fix: use the closest package.json as root when workspace not found fo… (
9257646 
vitejs#3374)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patak-dev patak-dev patak-dev approved these changes

@Shinigami92 Shinigami92 Shinigami92 approved these changes

Assignees
No one assigned
Labels
p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@antfu @patak-dev @Shinigami92