fix: inline webworker safari support

[Xerios]

Description

Issue related to this #2504

Safari doesn't play by the rules, so we have to adapt.

Base64 isn't accepted for inline webworkers on Safari, yet blobs are fine. This very simple change adapted from my own custom plugin solves this issue. Tested on multiple Tim Apple's devices and non-Tim Apple devices, works perfectly so far and it is currently used in production.

I'm aware that there's #2689 but this change is slimmer and frankly very simple compared to what the hell is going on in that thread.

---

What is the purpose of this pull request?

• Bug fix
• New Feature
• Documentation update
• Other

Before submitting the PR, please make sure you do the following

• Read the Contributing Guidelines.
• Read the Pull Request Guidelines and follow the Commit Convention.
• Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
• Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
• Ideally, include relevant tests that fail without this PR but pass with it.

[nihalgonsalves]

Nice! @NotWoods @modderme123 any thoughts?

[milomg]

This change seems reasonable and should fix some errors with inline workers. This issue does not make #2689 obsolete. Rather, it complements the work there that fixes non-inline workers in Safari and Firefox

[NotWoods]

createObjectURL creates a pointer to the blob. I believe it can be freed after creating the Worker with revokeObjectURL.

[Xerios]

Oh I didn't realize it required some manual memory management. In my project this is completely unnecessary since I only have long-lived webworkers, thus irrelevant to my use case. I guess one change I can do is just move the objectURL outside of that function, so that it doesn't recreate it on multiple calls.

I'm really curious to know how one would solve this issue in an automated way.

[milomg]

I believe the suggestion is to do (entirely untested)

const blob = new Blob([atob(\"${Buffer.from(output[0].code).toString('base64')}\")], { type: 'text/javascript;charset=utf-8' }); 
const objURL = (window.URL || window.webkitURL).createObjectURL(blob);
const worker = new Worker(obj);
(window.URL || window.webkitURL).revokeObjectURL(objURL);
return worker;

Edit: fixed the typo mentioned below

[NotWoods]

Yup, immediately revoking the URL as shown above will fix the issue.

Slight change in the snippet: Pass the URL to revoke, not the blob

const objURL = (window.URL || window.webkitURL).createObjectURL(blob);
const worker = new Worker(obj);
-(window.URL || window.webkitURL).revokeObjectURL(blob);
+(window.URL || window.webkitURL).revokeObjectURL(objURL);

[Xerios]

Using revokeObjectURL right after just like modderme123 stated, seems to do the job. Tested on iOS and Chrome.

I wrapped it in a try finally in case Worker fails to initialize ( haven't exactly tested this part, but in theory this should work )

[nihalgonsalves]

@Xerios Looks like the tests are now failing, can you take a look?

[Xerios]

Forgot about the minifier, used another piece of code to match against.