Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(preview): support custom hostname #3506

Merged
merged 1 commit into from
May 23, 2021
Merged

fix(preview): support custom hostname #3506

merged 1 commit into from
May 23, 2021

Conversation

g-plane
Copy link
Contributor

@g-plane g-plane commented May 22, 2021

Description

This PR fixes the preview command doesn't support custom hostname.

Additional context

I treat this PR as a fix instead of a feature, because its behavior should keep align with the default serve command. Also, when we use preview command without any CLI arguments, Vite tells us:

图片

However, if we pass --host argument to Vite, it will throw an error and say --host option is unknown, which should be a bug.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@g-plane g-plane added pending triage p3-minor-bug An edge case that only affects very specific usage (priority) and removed pending triage labels May 22, 2021
@patak-dev patak-dev merged commit 5979d0e into vitejs:main May 23, 2021
@g-plane g-plane deleted the fix-host branch May 23, 2021 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants