fix(preview): support custom hostname #3506
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the
preview
command doesn't support custom hostname.Additional context
I treat this PR as a fix instead of a feature, because its behavior should keep align with the default
serve
command. Also, when we usepreview
command without any CLI arguments, Vite tells us:However, if we pass
--host
argument to Vite, it will throw an error and say--host
option is unknown, which should be a bug.What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).