Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(preview): allow to disable HTTPS #3514

Merged
merged 1 commit into from
May 23, 2021
Merged

fix(preview): allow to disable HTTPS #3514

merged 1 commit into from
May 23, 2021

Conversation

g-plane
Copy link
Contributor

@g-plane g-plane commented May 23, 2021

Description

This PR fixes missing --https CLI argument of preview command which allows to enable or disable HTTPS.

Additional context

I treat this PR as a fix instead of a feature because its behavior should keep align with the default serve command.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@g-plane g-plane added the p3-minor-bug An edge case that only affects very specific usage (priority) label May 23, 2021
@antfu antfu merged commit cf1632e into vitejs:main May 23, 2021
@g-plane g-plane deleted the fix-https branch May 24, 2021 01:23
ygj6 pushed a commit to ygj6/vite that referenced this pull request Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants