Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ssr): include non-CSS assets in the manifest #3556

Merged
merged 4 commits into from
Jun 1, 2021

Conversation

ferdinando-ferreira
Copy link
Contributor

Description

Include non-CSS assets in the ssr manifest, as planned in the following TODO:

if (chunk.type === 'chunk' && !chunk.isEntry) {
// links for entry chunks are already generated in static HTML
// so we only need to record info for non-entry chunks
// TODO: also include non-CSS assets
const cssFiles = chunkToEmittedCssFileMap.get(chunk)
for (const id in chunk.modules) {
const mappedChunks = ssrManifest[id] || (ssrManifest[id] = [])
mappedChunks.push(base + chunk.fileName)
if (cssFiles) {
cssFiles.forEach((file) => {
mappedChunks.push(base + file)
})
}
}
}
}

Additional context

Also adds tests to the ssr-vue example. A font was included in the App.vue SFC to highlight the need to include entries in the manifest in the case of assets embedded in modules belonging to said entries.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Complete an existing functionality

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@Shinigami92 Shinigami92 marked this pull request as draft May 26, 2021 19:04
@Shinigami92 Shinigami92 marked this pull request as ready for review May 26, 2021 19:16
@Shinigami92 Shinigami92 added the p2-nice-to-have Not breaking anything but nice to have (priority) label May 26, 2021
@Shinigami92 Shinigami92 requested a review from antfu May 26, 2021 19:17
@antfu antfu merged commit adc7170 into vitejs:main Jun 1, 2021
ygj6 pushed a commit to ygj6/vite that referenced this pull request Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p2-nice-to-have Not breaking anything but nice to have (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants