Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS minification bug introduced in v2.3.8, breaking styles. #3947

Closed
craigrileyuk opened this issue Jun 24, 2021 · 2 comments
Closed

CSS minification bug introduced in v2.3.8, breaking styles. #3947

craigrileyuk opened this issue Jun 24, 2021 · 2 comments
Labels
duplicate This issue or pull request already exists

Comments

@craigrileyuk
Copy link

Describe the bug

In v2.3.8 of Vite, a bug is introduced where CSS is incorrectly minified. Spaces are removed in certain places which breaks the style rules.

Reproduction

https://github.com/craigrileyuk/vite-css-compilation-issue

System Info

System:
    OS: macOS 11.4
    CPU: (8) x64 Intel(R) Core(TM) i7-6700K CPU @ 4.00GHz
    Memory: 28.14 MB / 32.00 GB
    Shell: 5.8 - /bin/zsh
  Binaries:
    Node: 14.15.5 - ~/.nvm/versions/node/v14.15.5/bin/node
    Yarn: 1.22.10 - ~/.nvm/versions/node/v14.15.5/bin/yarn
    npm: 7.17.0 - ~/.nvm/versions/node/v14.15.5/bin/npm
  Browsers:
    Chrome: 91.0.4472.114
    Edge: 91.0.864.54
    Firefox: 89.0.1
    Firefox Developer Edition: 87.0
    Safari: 14.1.1
  npmPackages:
    @vitejs/plugin-vue: ^1.2.3 => 1.2.3 
    vite: ^2.3.8 => 2.3.8 

Used package manager: npm

Reproduction Process -->

  1. Run npm run dev
  2. Click on the color picker
  3. Inspect the swatch gradient element that appears
  4. Find the following CSS rule:
.p-colorpicker-panel .p-colorpicker-color {
	background: transparenturl("/node_modules/primevue/resources/images/color.png") no-repeat left top;
}
  1. Notice how 'transparent' and 'url' are smushed together, breaking the styling.

@patak-dev
Copy link
Member

Thanks for the report. Duplicate of #3922, this has been solved in #3926

@patak-dev patak-dev added duplicate This issue or pull request already exists and removed pending triage labels Jun 24, 2021
@github-actions
Copy link

This issue gets locked because it has been closed for more than 14 days.

@github-actions github-actions bot locked and limited conversation to collaborators Jul 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants