Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(css): skip comma when matching css url #4004

Merged
merged 1 commit into from
Jun 29, 2021
Merged

Conversation

ikeq
Copy link
Contributor

@ikeq ikeq commented Jun 28, 2021

Description

I think it would be better to fix the multiple css url issue by correcting the regex, original issue #3922.

Issue review:

The comma is removed when there are multiple url().

.test {
  background-image: url(foo.png),url(bar.png);
}

resulting in

.test {
  background-image: url(foo.png)url(bar.png);
}

Debugging

vite-debug

Issue fixed after correcting the regex:

vite-debug-fix


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@antfu
Copy link
Member

antfu commented Jun 28, 2021

Duplicated with #3926?

@ikeq
Copy link
Contributor Author

ikeq commented Jun 28, 2021

This pr revert #3926 by providing a better solution.

@patak-dev patak-dev merged commit 7d0bc26 into vitejs:main Jun 29, 2021
aleclarson pushed a commit to aleclarson/vite that referenced this pull request Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants