-
-
Notifications
You must be signed in to change notification settings - Fork 6.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chunks reporting a preload link warning in Firefox #4051
Comments
It seems like that this is a firefox specific bug or it might be that it's a bug with any browser that doesn't support the real type of Seems like this is the code that "causes" this bug along when the link rel is added for script files. I can look a little more into this, though it seems to go away when instead of MDN Links: |
Prefetch might not be the right rep link either actually. I'm not sure what the right way to do this for Firefox, and potentially Safari... |
Thanks for digging into this @johnpangalos, would you try to yarn link vite with feat: modulepreload polyfill #4058? |
I tested and #4058 should solve this issue 👍🏼 |
Wow, that was quick! Let me know if you need anything else. Thanks again! |
Describe the bug
When using lazy loading assets, we are getting this warning when running in Firefox:
Reproduction
Reproduction repo: https://github.com/JohnPangalos/vite-preload-firefox-error
Reproduction steps:
System Info
System: OS: macOS 11.4 CPU: (8) arm64 Apple M1 Memory: 105.33 MB / 8.00 GB Shell: 5.8 - /bin/zsh Binaries: Node: 16.2.0 - /var/folders/gj/38htw22s6zj_nw81r9647xg80000gn/T/fnm_multishells/99920_1625049615026/bin/node Yarn: 1.22.10 - /opt/homebrew/bin/yarn npm: 7.13.0 - /var/folders/gj/38htw22s6zj_nw81r9647xg80000gn/T/fnm_multishells/99920_1625049615026/bin/npm Browsers: Chrome: 91.0.4472.114 Firefox: 89.0.2 Safari: 14.1.1 npmPackages: vite: ^2.3.8 => 2.3.8
Used Package Manager
npm
Logs
The text was updated successfully, but these errors were encountered: