Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server): keep port when modifying the config file #4460

Merged
merged 3 commits into from
Aug 3, 2021
Merged

fix(server): keep port when modifying the config file #4460

merged 3 commits into from
Aug 3, 2021

Conversation

ltaoo
Copy link
Contributor

@ltaoo ltaoo commented Aug 1, 2021

Description

console.log('start vite server');
const server = await vite.createServer({
  root: process.cwd(),
});
server.listen(8000);

I use createServer directly like above, when I modify vite.config.js file, the port is no longer 8000 but the default 3000.

Or make listen not support the port param.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@Shinigami92
Copy link
Member

Could you link a bug issue together with a reproduction?

@ltaoo ltaoo changed the title fix(server): can't reuse the port previously used to invoke listen when modify the config file. fix(server): can't reuse the port previously used to invoke listen when modify the config file. (fix #4464) Aug 1, 2021
@ltaoo ltaoo changed the title fix(server): can't reuse the port previously used to invoke listen when modify the config file. (fix #4464) fix(server): can't reuse the port previously used to invoke listen when modify the config file. Aug 1, 2021
@ltaoo
Copy link
Contributor Author

ltaoo commented Aug 1, 2021

bug description #4464 @Shinigami92

@Shinigami92 Shinigami92 added p3-minor-bug An edge case that only affects very specific usage (priority) and removed pending triage labels Aug 1, 2021
@Shinigami92 Shinigami92 linked an issue Aug 1, 2021 that may be closed by this pull request
6 tasks
Shinigami92
Shinigami92 previously approved these changes Aug 1, 2021
packages/vite/src/node/server/index.ts Outdated Show resolved Hide resolved
@patak-dev patak-dev changed the title fix(server): can't reuse the port previously used to invoke listen when modify the config file. fix(server): keep port when modifying the config file Aug 3, 2021
@patak-dev patak-dev merged commit 056b17e into vitejs:main Aug 3, 2021
aleclarson pushed a commit to aleclarson/vite that referenced this pull request Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

the port changed when modfiy vite.config.js
4 participants