feat: import .webmanifest assets as URL
#4515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leading to a slightly better DX when users do
```js
/* Before this PR:
import manifest from './path/to/app.webmanifest?url'
*/
// After this PR:
import manifest from './path/to/app.webmanifest'
const manifestMetaTag = ` <link rel="manifest" href=${manifest} crossorigin="use-credentials">`
```
antfu
approved these changes
Aug 5, 2021
|
@antfu do you think we can include this one in the beta? Or should we wait to discuss with the team? |
brillout
changed the title
.webmanifest to known asset types.webmanifest assets as URL
|
I think it's non-controversial, we could just merge it. |
patak-dev
approved these changes
Aug 5, 2021
aleclarson
pushed a commit
to aleclarson/vite
that referenced
this pull request
Nov 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leading to a slightly better DX.