-
-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow custom vite env prefix #4676
Conversation
docs/config/index.md
Outdated
@@ -333,6 +333,18 @@ export default defineConfig(async ({ command, mode }) => { | |||
|
|||
See [here](/guide/env-and-mode#env-files) for more about environment files. | |||
|
|||
### envVariblePrefix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure whether envVariblePrefix
is a good name? I'm open to a better name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My preference would be to use envPrefix
. We can leave the final call to be discussed with the rest of the team though this week.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have strong opinion here, both names are okay
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the suggestions. I'm changing to envPrefix
for now and waiting for the final call.
ping @benmccann, just so you are aware of this new option in case it is useful for SvelteKit |
Thanks! This is nice. I like the idea of using something like |
This is great. Thank you! Could we mention that |
We are not including the version when a feature has been added at this point in the documentation. IMO, since the project is young we can assume most of the people will be on latest fairly quickly. How to add this info to the docs and when should be discussed for all options at one point. The best way to see when features were added is to follow the changelog |
close #4194
Description
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).