Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(plugin-legacy): add externalSystemJS option #5024

Merged
merged 1 commit into from Sep 24, 2021
Merged

feat(plugin-legacy): add externalSystemJS option #5024

merged 1 commit into from Sep 24, 2021

Conversation

OrekiSH
Copy link
Contributor

@OrekiSH OrekiSH commented Sep 22, 2021 •
edited

Description

Enabling this option will exclude systemjs/dist/s.min.js inside polyfills-legacy chunk. It's useful in Micro Frontends case I think.

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@Shinigami92 Shinigami92 added p2-nice-to-have Not breaking anything but nice to have (priority) plugin: legacy labels Sep 22, 2021
antfu
antfu approved these changes Sep 24, 2021
View reviewed changes
Copy link
Member

@antfu antfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I will bring this to this week's meeting with the team.

@patak-dev patak-dev merged commit 60b6f55 into vitejs:main Sep 24, 2021
aleclarson pushed a commit to aleclarson/vite that referenced this pull request Nov 8, 2021
@OrekiSH @aleclarson
feat(plugin-legacy): add externalSystemJS option (vitejs#5024)
e855e19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yyx990803 yyx990803 yyx990803 approved these changes

@antfu antfu antfu approved these changes

Assignees
No one assigned
Labels
p2-nice-to-have Not breaking anything but nice to have (priority) plugin: legacy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@OrekiSH @yyx990803 @antfu @patak-dev @Shinigami92