Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin-react): support import namespace in parseReactAlias #5313

Merged
merged 6 commits into from
Jun 12, 2022

Conversation

aleclarson
Copy link
Member

@aleclarson aleclarson commented Oct 15, 2021

Description

When @vitejs/plugin-react parses node_modules, it looks for a React import. What it doesn't look for, however, is…

import * as React from "react"

…even though it should. This PR adds that.

To be clear, this only affects parsing of node_modules. This syntax is already supported for project files.

Additional context

I've also made the regexes less strict about whitespace, and I added some unit tests.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@aleclarson aleclarson added the p4-important Violate documented behavior or significantly improves performance (priority) label Oct 15, 2021
@bluwy bluwy added p3-minor-bug An edge case that only affects very specific usage (priority) plugin: react and removed p4-important Violate documented behavior or significantly improves performance (priority) labels Jun 12, 2022
bluwy
bluwy previously approved these changes Jun 12, 2022
@patak-dev patak-dev merged commit 05b91cd into vitejs:main Jun 12, 2022
@sapphi-red sapphi-red mentioned this pull request Jun 30, 2022
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants