Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(html): tags prepend doctype regex #5315

Merged
merged 4 commits into from
Oct 17, 2021
Merged

fix(html): tags prepend doctype regex #5315

merged 4 commits into from
Oct 17, 2021

Conversation

patak-dev
Copy link
Member

@patak-dev patak-dev commented Oct 15, 2021 •
edited
Loading

Description

Fixes a regression in the doctype regex. There are new tests for an html without a tag.
The build result of this new test is injecting some scripts (the script modules for the app) before . This is unrelated to this fix and we should fix it in another PR. I think that if we specify inject to head, a head tag should be created if there isn't one.

The regex issue (no groups) was the reason why we got a 0 in the output here #5285, when the head regex was not matching due to attrs (issue fixed here #5311)

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

@patak-dev patak-dev added the p4-important Violate documented behavior or significantly improves performance (priority) label Oct 15, 2021
@simnalamburt simnalamburt mentioned this pull request Oct 16, 2021
Closed
7 tasks
simnalamburt added a commit to simnalamburt/vue-practice that referenced this pull request Oct 16, 2021
@simnalamburt
Workaround Vitejs bug
dc61c9e 
References:
  vitejs/vite#5285 (comment)
  vitejs/vite#5315
@patak-dev patak-dev linked an issue Oct 17, 2021 that may be closed by this pull request
"0 0" in the body with vite 2.6.7 when head tag has attributes #5285
Closed
7 tasks
@patak-dev patak-dev merged commit 256b2bb into main Oct 17, 2021
@patak-dev patak-dev deleted the fix/doctype-regex branch October 17, 2021 18:17
@patak-dev patak-dev mentioned this pull request Oct 17, 2021
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
p4-important Violate documented behavior or significantly improves performance (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"0 0" in the body with vite 2.6.7 when head tag has attributes
1 participant
@patak-dev