fix(html): tags prepend doctype regex #5315
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a regression in the doctype regex. There are new tests for an html without a tag.
The build result of this new test is injecting some scripts (the script modules for the app) before . This is unrelated to this fix and we should fix it in another PR. I think that if we specify inject to head, a head tag should be created if there isn't one.
The regex issue (no groups) was the reason why we got a
0
in the output here #5285, when the head regex was not matching due to attrs (issue fixed here #5311)What is the purpose of this pull request?