Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(plugin-vue): multiple vue files using the same src file (fix #5925, #5447) #5994

Merged
merged 7 commits into from Dec 8, 2021
Merged

fix(plugin-vue): multiple vue files using the same src file (fix #5925, #5447) #5994

merged 7 commits into from Dec 8, 2021

Conversation

poyoho
Copy link
Member

@poyoho poyoho commented Dec 8, 2021 •
edited

Description

fix #5925
fix #5447

Additional context

use @vue/compile generate id for the cache key.

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@poyoho poyoho changed the title fix: multiple vue files use the same src file, will be overwritten cache #5925 fix: multiple vue files use the same src file, will be overwritten cache Dec 8, 2021
@poyoho poyoho changed the title fix: multiple vue files use the same src file, will be overwritten cache fix: multiple vue files use the same src file, will be overwritten cache (fix #5925) Dec 8, 2021
@poyoho poyoho changed the title fix: multiple vue files use the same src file, will be overwritten cache (fix #5925) fix(plugin-vue): multiple vue files use the same src file, will be overwritten cache (fix #5925) Dec 8, 2021
@poyoho poyoho changed the title fix(plugin-vue): multiple vue files use the same src file, will be overwritten cache (fix #5925) fix(plugin-vue): multiple vue files use the same src file, will be overwritten cache (fix #5925, #5447) Dec 8, 2021
sodatea
sodatea previously requested changes Dec 8, 2021
View reviewed changes
Copy link
Member

@sodatea sodatea left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the failing tests

@sodatea sodatea added plugin: vue p3-minor-bug An edge case that only affects very specific usage (priority) labels Dec 8, 2021
Shinigami92
Shinigami92 previously approved these changes Dec 8, 2021
View reviewed changes
Copy link
Member

@Shinigami92 Shinigami92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me
@sodatea was there anything why you didn't approved it?

@poyoho poyoho requested a review from sodatea December 8, 2021 09:22
@patak-dev patak-dev changed the title fix(plugin-vue): multiple vue files use the same src file, will be overwritten cache (fix #5925, #5447) fix(plugin-vue): multiple vue files using the same src file (fix #5925, #5447) Dec 8, 2021
@patak-dev patak-dev merged commit df7aec7 into vitejs:main Dec 8, 2021
@sufuwang
Copy link
Contributor

i have a question, When will it be released ？

@Niputi Niputi mentioned this pull request Dec 28, 2021
Closed
9 tasks
@sapphi-red sapphi-red mentioned this pull request May 6, 2022
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sodatea sodatea sodatea approved these changes

@Shinigami92 Shinigami92 Shinigami92 approved these changes

Assignees
No one assigned
Labels
p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

@vitejs/plugin-vue build failed Import the same style file with scoped attribute
5 participants
@poyoho @sufuwang @sodatea @Shinigami92 @patak-dev