Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: block.scoped is undefined #5977

Closed
wants to merge 2 commits into from
Closed

fix: block.scoped is undefined #5977

wants to merge 2 commits into from

Conversation

sufuwang
Copy link
Contributor

@sufuwang sufuwang commented Dec 6, 2021

Description

测试项目:https://github.com/sufuWang/uniapp_vite/tree/feature/vite
当我在组件和页面引用同一个 less 文件时,会打包失败,因为 plugin-vue 中的 cache 在更新时,会根据 key 值覆盖 value ,导致对 descriptor 的索引失败,详情请克隆测试工程复现此 bug

test project :https://github.com/sufuWang/uniapp_vite/tree/feature/vite
When I reference the same less file in the component and the page, the package fails, because the cache in plugin-vue overwrites the value according to the key value when it is updated, so the index of descriptor fails. For details, please refer to the clone test project to reproduce this bug

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@bluwy bluwy added p3-minor-bug An edge case that only affects very specific usage (priority) plugin: vue labels Dec 6, 2021
@Niputi
Copy link
Contributor

Niputi commented Dec 28, 2021

is this still relevant after #5994 got merged?

@patak-dev
Copy link
Member

Closing due to inactivity. @sufuwang, please open a new PR against main if the changes that @Niputi mentioned didn't fix your problem.

@patak-dev patak-dev closed this Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants