Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get file from @fs 404 when the url has query #9398

Closed
7 tasks done
candy-Tong opened this issue Jul 27, 2022 · 1 comment
Closed
7 tasks done

get file from @fs 404 when the url has query #9398

candy-Tong opened this issue Jul 27, 2022 · 1 comment
Labels
duplicate This issue or pull request already exists

Comments

@candy-Tong
Copy link
Contributor

candy-Tong commented Jul 27, 2022

Describe the bug

image

this is becase the ? has been encode and sirv can not parse it and clean the query
image

so it can not lookup the file
image

This problem is happend since 2.9.14. In this pull request #8979

How i found this problem?
https://unpkg.com/view-ui-plus@1.3.1/dist/styles/viewuiplus.css
image

when i import the css build by view-design ,i found this project. The css has use a url with query v=3.0.0
It add the encodeUrIComponent that cause the ? has been encode and the sirv can not parse it correctly


i think it can just clean the query when serve the local file

Reproduction

none

System Info

win10
2.9.14

Used Package Manager

pnpm

Logs

No response

Validations

@sapphi-red
Copy link
Member

duplicate of #9148. This is already fixed by #9173. Please upgrade to 3.0.2+.

@sapphi-red sapphi-red added duplicate This issue or pull request already exists and removed pending triage labels Jul 27, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Aug 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants