fix: plugin legacy - module output doesn't support Safari 10 #10100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mport' keyword inside module bundle to fix safari 10 syntax error
4 tasks
marco-prontera
changed the title
|
If you don't like the parameter question, then we should check if it is possible to block the execution of the "modern" output in Safari 10 and favor the execution of the legacy version. How about? |
|
I think it is intended to run the legacy chunk for Safari 10 because Safari 10 does not support dynamic import and related: #3885 |
next time I will check better, sorry |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using the plugin-legacy the modern bundle of the app includes the dynamic import, and in safari 10 it throws a syntax error that blocks the parsing and the execution of the entire application.
safari 10.1 Syntax Error Unexpected Keyword importSince this import is a thing used for a specific purpose I just implemented a parameter that let me prevent the plugin from using that forced dynamic import and keep the application running also in safari 10.
closes #10099
Additional context
With this plugin, we just inject the
Safari 10 noModule fix, but when the 'esm' version of the application is parsed inside the Safari 10 browser and read the 'import' keyword the Syntax Error is thrown.What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).