Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix vue-ssr test warning #10399

Merged
merged 1 commit into from
Oct 10, 2022

Conversation

sapphi-red
Copy link
Member

Description

The following warning were shown when running pnpm test ssr-vue.

[Vue warn]: setup() return property "_p" should not start with "$" or "_" which are reserved prefixes for Vue internals.
[Vue warn]: setup() return property "$id" should not start with "$" or "_" which are reserved prefixes for Vue internals.
[Vue warn]: setup() return property "$onAction" should not start with "$" or "_" which are reserved prefixes for Vue internals.
[Vue warn]: setup() return property "$patch" should not start with "$" or "_" which are reserved prefixes for Vue internals.
[Vue warn]: setup() return property "$reset" should not start with "$" or "_" which are reserved prefixes for Vue internals.
[Vue warn]: setup() return property "$subscribe" should not start with "$" or "_" which are reserved prefixes for Vue internals.
[Vue warn]: setup() return property "$dispose" should not start with "$" or "_" which are reserved prefixes for Vue internals.
[Vue warn]: setup() return property "_hotUpdate" should not start with "$" or "_" which are reserved prefixes for Vue internals.

refs #10366

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added the p1-chore Doesn't change code behavior (priority) label Oct 10, 2022
@bluwy bluwy merged commit 3a87593 into vitejs:main Oct 10, 2022
@sapphi-red sapphi-red deleted the chore/vue-ssr-test-warning branch October 10, 2022 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p1-chore Doesn't change code behavior (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants