Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(legacy): restore entry chunk CSS inlining, reverts #9761 #10496

Merged
merged 1 commit into from
Oct 17, 2022

Conversation

sapphi-red
Copy link
Member

Description

When an entry chunk is imported by dynamic import, the CSS wasn't loaded in legacy mode.

fixes #10285
refs #10185
reverts #9761

Additional context

#10285 (comment)


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added plugin: legacy p3-minor-bug An edge case that only affects very specific usage (priority) regression The issue only appears after a new release labels Oct 17, 2022
@patak-dev patak-dev merged commit 9cc808e into vitejs:main Oct 17, 2022
@sapphi-red sapphi-red deleted the fix/legacy-entry-css-missing branch October 18, 2022 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3-minor-bug An edge case that only affects very specific usage (priority) plugin: legacy regression The issue only appears after a new release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Entry points doesn't inline CSS, but client-side navigation might load another entry point
3 participants