Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(config): don't use module condition (import.meta.resolve) (fixes #10430) #10528

Merged
merged 2 commits into from Oct 20, 2022
Merged

fix(config): don't use module condition (import.meta.resolve) (fixes #10430) #10528

merged 2 commits into from Oct 20, 2022

Conversation

sapphi-red
Copy link
Member

Description

Alternative to #10495. See #10495.

superseds #10442 #10495
fixes #10430
refs #10254 #10347 #10420

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added the p4-important Violate documented behavior or significantly improves performance (priority) label Oct 19, 2022
@sapphi-red
Copy link
Member Author

/ecosystem-ci run

@vite-ecosystem-ci
Copy link

vite-ecosystem-ci bot commented Oct 19, 2022 •
edited

📝 Ran ecosystem CI: Open

suite result
astro ✅ success
histoire ✅ success
iles ✅ success
ladle ✅ success
laravel ✅ success
marko ✅ success
nuxt-framework ✅ success
rakkas ✅ success
svelte ❌ failure
vite-plugin-ssr ❌ failure
vite-setup-catalogue ✅ success
vitepress ✅ success
vitest ✅ success
windicss ✅ success

@patak-dev patak-dev added this to the 3.2 milestone Oct 19, 2022
@patak-dev patak-dev requested a review from bluwy October 19, 2022 19:23
@patak-dev patak-dev merged commit 64f19b9 into vitejs:main Oct 20, 2022
This was referenced Oct 20, 2022
Closed
Closed
@sapphi-red sapphi-red mentioned this pull request Oct 28, 2022
Merged
9 tasks
@aleclarson aleclarson mentioned this pull request Nov 13, 2022
Closed
7 tasks
@sapphi-red sapphi-red deleted the fix/config-import-meta-resolve branch April 20, 2023 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patak-dev patak-dev patak-dev approved these changes

@bluwy bluwy bluwy approved these changes

Assignees
No one assigned
Labels
p4-important Violate documented behavior or significantly improves performance (priority)
Projects
None yet
Milestone
3.2
Development

Successfully merging this pull request may close these issues.

Vite >=3.1.5 breaks Jotai babel plugins
3 participants
@sapphi-red @patak-dev @bluwy