Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: relocated logger to respect config. #10787

merged 2 commits into from
Nov 7, 2022


Copy link

@qodesmith qodesmith commented Nov 4, 2022


This PR simply moves the location of where the logger is created further down in the code. This fixes #10780.

Additional context

The logger was being instantiated too early and wasn't respecting potential changes to the clearScreen config option that could have been changed via plugins. Now that the logger is instantiated after plugins are processed, it will pick up changes in the config correctly.

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@qodesmith qodesmith marked this pull request as ready for review November 4, 2022 20:51
@patak-dev patak-dev merged commit 52e64eb into vitejs:main Nov 7, 2022
Copy link

leonheess commented Nov 16, 2022

Can this maybe be added to Vite 3 as well? It's a major bug.

Copy link

bluwy commented Nov 17, 2022

Feel free to cherry pick this and send a PR merging into the v3 branch

Copy link

@bluwy done :)

patak-dev pushed a commit that referenced this pull request Nov 17, 2022
Co-authored-by: Aaron Cordova <>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

clearScreen option can't be overwritten via plugin
5 participants