Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin-vue): support scss/sass/less... hmr on custom template languages(fix #10677) #10844

merged 5 commits into from
Nov 22, 2022


Copy link

@Jevon617 Jevon617 commented Nov 9, 2022

Fix #10677
Related PR: #6987

This PR is supplementary to #6987.


Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

kabarchonok previously approved these changes Nov 10, 2022
@sapphi-red sapphi-red added plugin: vue feat: css feat: hmr p3-minor-bug An edge case that only affects very specific usage (priority) labels Nov 13, 2022
Copy link

bluwy commented Nov 14, 2022

I think we may want to discuss whether we're fine with exporting isCSSRequest or maybe the raw list of css extensions for this PR. But there are several usecases in the past where Svelte and Astro needs it too.

Copy link

Copy link

bluwy commented Nov 19, 2022

We discussed in the last meeting that exposing isCSSRequest is good. This PR needs a rebase and should be good to go.

Copy link
Contributor Author

I have merged the branch "main" into my branch.

@patak-dev patak-dev requested a review from bluwy November 22, 2022 10:45
@bluwy bluwy merged commit d413848 into vitejs:main Nov 22, 2022
fc pushed a commit to fc/vite that referenced this pull request Nov 23, 2022
@Jevon617 Jevon617 deleted the fix-10677 branch December 6, 2022 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
feat: css feat: hmr p3-minor-bug An edge case that only affects very specific usage (priority)
Archived in project

Successfully merging this pull request may close these issues.

CSS HMR not working with Vue + Pug + Tailwind CSS + Scss
6 participants