Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): remove null from CSSModulesOptions.localsConvention #10904


Copy link


I expect no one to set null to CSSModulesOptions.localsConvention. But it's technically a breaking change.

refs #10738

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added the p1-chore Doesn't change code behavior (priority) label Nov 13, 2022
@patak-dev patak-dev enabled auto-merge (squash) November 13, 2022 07:53
@patak-dev patak-dev merged commit a9978dd into vitejs:main Nov 13, 2022
@sapphi-red sapphi-red deleted the fix/remove-null-from-css-modules-localsconvention branch November 13, 2022 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
p1-chore Doesn't change code behavior (priority)
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants