Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use function to eval worker and glob options #10999

merged 6 commits into from
Nov 30, 2022


Copy link

@bluwy bluwy commented Nov 20, 2022


Use new Function() to parse worker and glob options. This should allow more flexible options syntax. Fixes #10961

This started as an experiment, but it works! But happy to discuss more or ditch this idea if there's concerns.

Additional context

Raw unprocessed benchmark:

  • new Function() is slightly faster over json5 (worker options), and seem to have equal perf to acorn (glob options).

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@bluwy bluwy marked this pull request as ready for review November 25, 2022 02:19
@bluwy bluwy added the p2-nice-to-have Not breaking anything but nice to have (priority) label Nov 25, 2022
sapphi-red previously approved these changes Nov 29, 2022
Copy link

@bluwy feel free to merge after resolving the conflicts, let realease a new patch after this one

@bluwy bluwy enabled auto-merge (squash) November 30, 2022 05:26
@patak-dev patak-dev merged commit f4c1264 into main Nov 30, 2022
@patak-dev patak-dev deleted the refactor-function-options branch November 30, 2022 06:41
futurGH pushed a commit to futurGH/vite that referenced this pull request Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
p2-nice-to-have Not breaking anything but nice to have (priority)
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants